mise au point

README.md

@@ -15,6 +15,7 @@ Role Variables
 --------------
 php_poolname: default www (version will be appended)
 php_version: default 74
+php_fpm_listen_url: no default
 php_fpm_pool_user: default apache
 php_fpm_pool_group: default apache
 php_fpm_listen_url: default 127.0.0.1:90{{ php_version }}
@@ -40,7 +41,7 @@ Including an example of how to use your role (for instance, with variables passe
   - role: tconstans.php-fpm
     vars:
       php_poolname: pool1
-      php_listen_url: "/srv/pool1/php-fpm.sock"
+      php_fpm_listen_url: "/srv/pool1/php-fpm.sock"
       php_version: 74
       php_packages:
       - php{{ php_version }}-php-mbstring
@@ -59,7 +60,7 @@ Including an example of how to use your role (for instance, with variables passe
   - role: tconstans.php-fpm
     vars:
       php_poolname: pool2
-      php_listen_url: "/srv/pool2/php-fpm.sock"
+      php_fpm_listen_url: "/srv/pool2/php-fpm.sock"
       php_version: 80
       php_packages:
       - php{{ php_version }}-php-zip

tasks/php-fpm.yml

@@ -1,26 +1,25 @@
 ---
 # tasks file for php-fpm
+#
+- name: rpm key
+  rpm_key:
+    state: present
+    key: https://rpms.remirepo.net/RPM-GPG-KEY-remi2018
+
 - name: install repository definitions
-  yum:
+  package:
     name:
     - epel-release
-    - http://rpms.remirepo.net/enterprise/remi-release-{{ ansible_distribution_major_version }}.rpm
+    - https://rpms.remirepo.net/enterprise/remi-release-{{ ansible_distribution_major_version }}.rpm
     - yum-utils
     state: present
 
-- name: activate given repo
-  ini_file:
-    path: /etc/yum.repos.d/remi-php{{ php_version }}.repo
-    section: "remi-php{{ php_version }}"
-    option: enabled
-    value: 1
-
 - name: create socket directory if needed
   file:
-    path: "{{ php_listen_url|dirname }}"
+    path: "{{ php_fpm_listen_url|dirname }}"
     state: directory
     owner: "{{ php_fpm_pool_user }}"
-  when: php_listen_url[0] == '/'
+  when: php_fpm_listen_url[0] == '/'
 
 
 - name: install php-fpm
@@ -50,4 +49,9 @@
   service:
     name: php{{php_version}}-php-fpm
     enabled: yes
-    state: started
+    state: started
+
+- name: configure logrotate
+  template:
+    src: logrotate.conf.jj
+    dest: /etc/logrotate.d/php-fpm.conf

templates/logrotate.conf.jj

@@ -0,0 +1,12 @@
+/var/opt/remi/php{{ php_version }}/log/php-fpm/*log {
+   daily
+   rotate 15
+   missingok
+   notifempty
+   sharedscripts
+   postrotate
+      /bin/systemctl reload php{{ php_version }}-php-fpm
+   endscript
+}
+
+